Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-133459 / 25.04 / Allow From Name and Email to be used with oAuth email config #11320

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

undsoft
Copy link
Collaborator

@undsoft undsoft commented Jan 10, 2025

Changes:

Email configuration form now allows From Email and From Name to be used with Gmail or Outlook.

Affects Reasoning
Documentation Changes to email config form options.

@undsoft undsoft requested a review from a team as a code owner January 10, 2025 00:57
@undsoft undsoft requested review from denysbutenko and removed request for a team January 10, 2025 00:57
@bugclerk bugclerk changed the title NAS-133459: Allow From Name and Email to be used with oAuth email config NAS-133459 / 25.04 / Allow From Name and Email to be used with oAuth email config Jan 10, 2025
@bugclerk
Copy link
Contributor

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.27%. Comparing base (6e330e6) to head (2eacba0).
Report is 2 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #11320       +/-   ##
===========================================
- Coverage   82.75%   53.27%   -29.49%     
===========================================
  Files        1654     1654               
  Lines       59133    59133               
  Branches     6210     6210               
===========================================
- Hits        48936    31502    -17434     
- Misses      10197    27631    +17434     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@denysbutenko denysbutenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@undsoft undsoft enabled auto-merge (squash) January 10, 2025 14:28
@undsoft undsoft merged commit fd8ff93 into master Jan 10, 2025
10 of 11 checks passed
@undsoft undsoft deleted the NAS-133459 branch January 10, 2025 15:01
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jan 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants